fix: case-insensitivity in the like() method when in use with accented characters
#9238
Conversation
michalsn
added
the
bug
| @@ -79,6 +79,12 @@ public function testLikeCaseInsensitive(): void | |||
| #[DataProvider('provideMultibyteCharacters')] | |||
| public function testLikeCaseInsensitiveWithMultibyteCharacter(string $match, string $result): void | |||
| { | |||
| if ($this->db->DBDriver === 'SQLSRV') { | |||
| $this->markTestSkipped( | |||
| 'Currently Builder class does not fully support Unicode strings in SQLSRV.' | |||
There was a problem hiding this comment.
To be honest, I didn’t fully understand the details of this topic. While researching, I came across the following information:
nchar-and-nvarchar-transact-sql
"Character data types that are either fixed-size, nchar, or variable-size, nvarchar. In SQL Server 2012 (11.x) and later versions, when a Supplementary Character (SC) enabled collation is used, these data types store the full range of Unicode character data and use the UTF-16 character encoding. If a non-SC collation is specified, then these data types store only the subset of character data supported by the UCS-2 character encoding."
Based on this information, it seems that when an SC collation is used, there shouldn’t be any limitations on Unicode character support, as UTF-16 is capable of storing the full range of Unicode characters.
If possible, please provide additional documentation or clarification on these changes and specify how the SC collation should be applied in this PR.
There was a problem hiding this comment.
I was going to post the details as a bug report, but I gave it another try after your comment.
You are right. When I was checking this, I set collation only for the value field. Apparently, we have to set it for the entire database to work properly. Because of this, I was only able to add Unicode string using N prefix.
Thank you!
There was a problem hiding this comment.
Thanks for the explanation.
|
@michalsn rebase is needed |
michalsn
force-pushed
the
fix/caseInsensitive
branch
from
3e3e722
to
7742124
Compare
|
@samsonasik Thanks, done. |
Co-authored-by: Pooya Parsa <[email protected]>
michalsn
force-pushed
the
fix/caseInsensitive
branch
from
7742124
to
3715280
Compare
Description
This PR fixes the case insensitivity option in the
like()method when we deal with accented characters.Closes #9236
Checklist: